[PATCH 16/31] drm/amd/display: Fix race.

Harry Wentland harry.wentland at amd.com
Fri May 12 15:20:49 UTC 2017

From: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com>

Problem :
A race between two adjecent page flips makes the earlier one
to release an alocated frame buffer for the subsequent one -
since there are 2 frambuffer swapped back and forth between flips,
the 'new' fb of the later flip is actually the 'previous' fb for the earlier flip.
Don't set fb->address = 0 in cleanup hook, this is unnecessery and
erases the newly cached adress that was set in prepare_fb of the second

Change-Id: I852ad2ee5122222e49dfc9c05e7488843d6a8915
Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com>
Reviewed-by: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com>
Acked-by: Harry Wentland <Harry.Wentland at amd.com>
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c
index 6fddf31cc4e4..8aeb10786b94 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c
@@ -1795,9 +1795,7 @@ static void dm_plane_helper_cleanup_fb(
-	}
-	afb->address = 0;
+	};
 int dm_create_validation_set_for_connector(struct drm_connector *connector,

More information about the amd-gfx mailing list