[PATCH 1/2] drm/amdgpu: fix re-program vm invalidate eng address range for gfxhub on resume

Huang Rui ray.huang at amd.com
Wed May 17 07:55:58 UTC 2017


On Wed, May 17, 2017 at 03:43:47PM +0800, Zhou, David(ChunMing) wrote:
> By this change, I suggest to remove mmhub/gfxhub_v1_0_ip_funcs and their
> IP block, unify them to gmc ip block, this way we cannot lost setting
> when resume back.
> 

>From hw side, wo won't have real gmc since this chip, mmhub and gfxhub(gc)
instead of it. Maybe we would better to align with hw desgin.

Thanks,
Rui

> Regards,
> David Zhou
> 
> On 2017年05月17日 15:38, Huang Rui wrote:
> > Signed-off-by: Huang Rui <ray.huang at amd.com>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c b/drivers/gpu/drm/amd/
> amdgpu/gfxhub_v1_0.c
> > index 005075f..41313514 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
> > @@ -368,7 +368,7 @@ static int gfxhub_v1_0_suspend(void *handle)
> >  
> >   static int gfxhub_v1_0_resume(void *handle)
> >   {
> > -     return 0;
> > +     return gfxhub_v1_0_hw_init(handle);
> >   }
> >  
> >   static bool gfxhub_v1_0_is_idle(void *handle)
> 


More information about the amd-gfx mailing list