[PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops
lukas at wunner.de
Mon May 22 14:04:07 UTC 2017
On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote:
> On Thu, May 18 2017, Lukas Wunner wrote:
> > Reported-by: Nicolai Stange <nicstange at gmail.com>
> > Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo")
> > Signed-off-by: Lukas Wunner <lukas at wunner.de>
> > ---
> > Awaiting a Tested-by: from Nicolai, but it's clear this is a bug and
> > needs to be fixed, so sending out with a proper commit message now.
> > The bug was only introduced to radeon, not amdgpu.
> Tested-by: Nicolai Stange <nicstange at gmail.com>
> Thanks for the quick fix!
> > @Alex Deucher: I could push this to drm-misc-fixes but then it wouldn't
> > land before -rc3 because Sean Paul has already sent out the -rc2 pull.
> > I notice you haven't sent out a pull for -rc2 yet, so maybe you want to
> > take it yourself? Whichever you prefer. Thanks & sorry for the breakage!
I've learned this morning that Alex is on vacation. I've pushed
the patch to drm-misc-fixes so that the issue is fixed in 4.12-rc3.
@Sean Paul: I've fast-forwarded to 4.12-rc2 before pushing, please
shout if I've done anything wrong. First time I'm doing this.
> > drivers/gpu/drm/radeon/radeon_kms.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
> > index 6a68d440bc44..d0ad03674250 100644
> > --- a/drivers/gpu/drm/radeon/radeon_kms.c
> > +++ b/drivers/gpu/drm/radeon/radeon_kms.c
> > @@ -116,7 +116,7 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)
> > if ((radeon_runtime_pm != 0) &&
> > radeon_has_atpx() &&
> > ((flags & RADEON_IS_IGP) == 0) &&
> > - !pci_is_thunderbolt_attached(rdev->pdev))
> > + !pci_is_thunderbolt_attached(dev->pdev))
> > flags |= RADEON_IS_PX;
> > /* radeon_device_init should report only fatal error
More information about the amd-gfx