[PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs

[Kai Wasserbäch]

Hey Michel,
Michel Dänzer wrote on 29.05.2017 11:20:
> From: Michel Dänzer <michel.daenzer at amd.com>
> 
> Even if CONFIG_DRM_AMDGPU_CIK is enabled.
> 
> There is no feature parity yet for CIK, in particular amdgpu doesn't
> support HDMI/DisplayPort without DC.

that can't be correct. I'm using amdgpu on a CIK ASIC (Hawaii Pro) and my
monitor is connected by DisplayPort. From my Xorg.0.log:
> [    37.811] (II) AMDGPU(0): EDID for output DisplayPort-0
> [    37.811] (II) AMDGPU(0): Manufacturer: SAM  Model: 83d  Serial#: 0
> [    37.811] (II) AMDGPU(0): Year: 2011  Week: 7
> [    37.811] (II) AMDGPU(0): EDID Version: 1.4
> [    37.811] (II) AMDGPU(0): Digital Display Input
> [    37.811] (II) AMDGPU(0): 8 bits per channel
> [    37.811] (II) AMDGPU(0): Digital interface is DisplayPort
> [    37.811] (II) AMDGPU(0): Max Image Size [cm]: horiz.: 52  vert.: 32
> [    37.811] (II) AMDGPU(0): Gamma: 2.20
> [    37.811] (II) AMDGPU(0): DPMS capabilities: Off
> [    37.811] (II) AMDGPU(0): Supported color encodings: RGB 4:4:4 
> [    37.811] (II) AMDGPU(0): First detailed timing is preferred mode
> [    37.811] (II) AMDGPU(0): Preferred mode is native pixel format and refresh rate
> [    37.811] (II) AMDGPU(0): redX: 0.650 redY: 0.337   greenX: 0.296 greenY: 0.604
> [    37.811] (II) AMDGPU(0): blueX: 0.147 blueY: 0.074   whiteX: 0.312 whiteY: 0.329
> [    37.811] (II) AMDGPU(0): Supported established timings: [...]

Or do you mean some features like audio over HDMI/DP?

> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/Kconfig      | 8 ++++----
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
>  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 7 +++++--
>  drivers/gpu/drm/radeon/radeon_drv.c     | 4 ++--
>  drivers/gpu/drm/radeon/radeon_kms.c     | 5 +----
>  5 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig
> index 8d36087fc186..e0121f8b436e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> @@ -17,11 +17,11 @@ config DRM_AMDGPU_CIK
>  	help
>  	  Choose this option if you want to enable support for CIK asics.
>  
> -	  CIK is already supported in radeon. If you enable this option,
> -	  support for CIK will be provided by amdgpu and disabled in
> -	  radeon by default. Use module options to override this:
> +	  CIK is already supported in radeon. Support for SI in amdgpu
> +	  will be disabled by default and is still provided by radeon.
> +	  Use module options to override this:
>  
> -	  radeon.cik_support=1 amdgpu.cik_support=0
> +	  radeon.cik_support=0 amdgpu.cik_support=1

What happens if I have radeon blacklisted? Do I still need to set this
additional flag? If so I'd kindly request to at least fall back to amdgpu if
somebody blacklisted radeon (or didn't compile it). Maybe issue a warning that
not all features are supported yet.

Thank you for your consideration!

Cheers,
Kai