[PATCH 1/3] drm/amdgpu: Really leave SI support disabled by default

Christian König deathsimple at vodafone.de
Mon May 29 17:18:24 UTC 2017


Am 29.05.2017 um 11:20 schrieb Michel Dänzer:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> The default option value didn't match the help text and intention.
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

I'm still unsure about the last one. The feature parity is a good 
argument but on the other hand we want people to use amdgpu for CIK 
these days, don't we?

Anyway Reviewed-by: Christian König <christian.koenig at amd.com>.

Regards,
Christian.

> ---
>
> Maybe this can be squashed into the commit adding this option when it
> goes upstream.
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 17ecc2542af5..76dea5fe620b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -234,7 +234,7 @@ MODULE_PARM_DESC(param_buf_per_se, "the size of Off-Chip Pramater Cache per Shad
>   module_param_named(param_buf_per_se, amdgpu_param_buf_per_se, int, 0444);
>   
>   #ifdef CONFIG_DRM_AMDGPU_SI
> -int amdgpu_si_support = 1;
> +int amdgpu_si_support = 0;
>   MODULE_PARM_DESC(si_support, "SI support (1 = enabled, 0 = disabled (default))");
>   module_param_named(si_support, amdgpu_si_support, int, 0444);
>   #endif




More information about the amd-gfx mailing list