[PATCH 12/19] drm/amd/display: Don't guard x86 in Makefile

Kai Wasserb├Ąch kai at dev.carbon-project.org
Wed May 31 16:30:07 UTC 2017


Hey Harry,
you should drop this patch and remove the addition from patch 3 AFAICT.


Cheers,
Kai

P.S.: IIRC the conclusion of the last discussion was, that this code is needed
on non-x86 hardware as well. Shouldn't there at least be some TODO added
somewhere in the DCN code or maybe now in the Kconfig option, stating that this
needs to be fixed for other arches?


Harry Wentland wrote on 31.05.2017 17:52:
> make-kpkg doesn't seem to like it
> 
> Change-Id: Ia589318e8632de57286c4a3d63a0a92a6cb96af3
> Signed-off-by: Harry Wentland <harry.wentland at amd.com>
> Reviewed-by: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com>
> Acked-by: Harry Wentland <Harry.Wentland at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/calcs/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/Makefile b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
> index 2e4ce0918c02..a095472bf4b5 100644
> --- a/drivers/gpu/drm/amd/display/dc/calcs/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/calcs/Makefile
> @@ -3,11 +3,9 @@
>  # It calculates Bandwidth and Watermarks values for HW programming
>  #
>  
> -ifeq ($(ARCH),x86)
>  CFLAGS_dcn_calcs.o := -mhard-float -msse -mpreferred-stack-boundary=4
>  CFLAGS_dcn_calc_auto.o := -mhard-float -msse -mpreferred-stack-boundary=4
>  CFLAGS_dcn_calc_math.o := -mhard-float -msse -mpreferred-stack-boundary=4
> -endif
>  
>  BW_CALCS = dce_calcs.o bw_fixed.o custom_float.o

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170531/beb629b7/attachment-0001.sig>


More information about the amd-gfx mailing list