[bug report] drm/amd/display: Merge amdgpu_dm_types and amdgpu_dm

[Dan Carpenter]

Hello Harry Wentland,

The patch e7b07ceef2a6: "drm/amd/display: Merge amdgpu_dm_types and
amdgpu_dm" from Aug 10, 2017, leads to the following static checker
warning:

	drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3895 amdgpu_dm_commit_planes()
	error: double unlock 'spin_lock:&crtc->dev->event_lock'

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
  3883  
  3884                  pflip_needed = !state->allow_modeset;
  3885  
  3886                  spin_lock_irqsave(&crtc->dev->event_lock, flags);
  3887                  if (acrtc_attach->pflip_status != AMDGPU_FLIP_NONE) {
  3888                          DRM_ERROR("%s: acrtc %d, already busy\n",
  3889                                    __func__,
  3890                                    acrtc_attach->crtc_id);
  3891                          spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
                                ^^^^^^^^^^^^^^^^^^^^^^
  3892                          /* In commit tail framework this cannot happen */
  3893                          WARN_ON(1);
  3894                  }
  3895                  spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
                        ^^^^^^^^^^^^^^^^^^^^^^
Double unlock.

  3896  
  3897                  if (!pflip_needed) {

regards,
dan carpenter