[PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)

[Christian König]

Am 06.11.2017 um 19:28 schrieb Tom St Denis:
> On 06/11/17 05:01 AM, Christian König wrote:
>> Am 04.11.2017 um 18:15 schrieb Tom St Denis:
>>> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
>>
>> Still not perfect, but good enough for now. Patch is Tested-by: 
>> Christian König <christian.koenig at amd.com>.
>>
>> I think you need to rework the VM walking a bit, cause we need to 
>> support the T bit as well in the future and your code make a few 
>> assumptions which doesn't allow that.
>
> Doesn't the T bit imply V=0 which means the page isn't backed by 
> memory.  Not much umr could do about that other than to print out the 
> T bit.

No, the T bit means translate further. In other words it is the counter 
part of the P bit and means that a PTE should be handled as a PDE.

But for this to have meaning you also need to handle the fragment size 
as well (Now I have you totally confused, haven't I? :).

Cheers,
Christian.

>
> Tom
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx