[PATCH] amdgpu/dc: fix non-ansi function decls.

Christian K├Ânig ckoenig.leichtzumerken at gmail.com
Mon Nov 6 19:41:36 UTC 2017


Am 06.11.2017 um 20:17 schrieb Dave Airlie:
> From: Dave Airlie <airlied at redhat.com>
>
> smatch reported:
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce80_get_table'
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce110/command_table_helper_dce110.c:361:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce110_get_table'
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper_dce112.c:415:72: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table'
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce112/command_table_helper2_dce112.c:415:73: warning: non-ANSI function declaration of function 'dal_cmd_tbl_helper_dce112_get_table2'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:148:34: warning: non-ANSI function declaration of function 'dc_create_gamma'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:178:50: warning: non-ANSI function declaration of function 'dc_create_transfer_func'
>
> This fixes them.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>   .../gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c  | 2 +-
>   .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c | 2 +-
>   .../gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c  | 2 +-
>   .../gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c    | 2 +-
>   drivers/gpu/drm/amd/display/dc/core/dc_surface.c                      | 4 ++--
>   5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c b/drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c
> index 8049320..ca24154 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/dce110/command_table_helper_dce110.c
> @@ -358,7 +358,7 @@ static const struct command_table_helper command_table_helper_funcs = {
>    * const struct command_table_helper **h - [out] struct of functions
>    *
>    */
> -const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table()
> +const struct command_table_helper *dal_cmd_tbl_helper_dce110_get_table(void)
>   {
>   	return &command_table_helper_funcs;
>   }

BTW may I ask what those accessors functions are good for? That looks 
just like a LOC increase to me.

Why not export the command_table_helper_funcs directly?

Regards,
Christian.

> diff --git a/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c b/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c
> index d342cde..0237ae5 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper2_dce112.c
> @@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
>    * const struct command_table_helper **h - [out] struct of functions
>    *
>    */
> -const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2()
> +const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table2(void)
>   {
>   	return &command_table_helper_funcs;
>   }
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c b/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c
> index 48e5996..452034f 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/dce112/command_table_helper_dce112.c
> @@ -412,7 +412,7 @@ static const struct command_table_helper command_table_helper_funcs = {
>    * const struct command_table_helper **h - [out] struct of functions
>    *
>    */
> -const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table()
> +const struct command_table_helper *dal_cmd_tbl_helper_dce112_get_table(void)
>   {
>   	return &command_table_helper_funcs;
>   }
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c b/drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c
> index 295e16e..8b30b55 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/dce80/command_table_helper_dce80.c
> @@ -348,7 +348,7 @@ static const struct command_table_helper command_table_helper_funcs = {
>   		dal_cmd_table_helper_encoder_mode_bp_to_atom,
>   };
>   
> -const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table()
> +const struct command_table_helper *dal_cmd_tbl_helper_dce80_get_table(void)
>   {
>   	return &command_table_helper_funcs;
>   }
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_surface.c b/drivers/gpu/drm/amd/display/dc/core/dc_surface.c
> index 5aa2270..ade5b8e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_surface.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_surface.c
> @@ -145,7 +145,7 @@ void dc_gamma_release(struct dc_gamma **gamma)
>   	*gamma = NULL;
>   }
>   
> -struct dc_gamma *dc_create_gamma()
> +struct dc_gamma *dc_create_gamma(void)
>   {
>   	struct dc_gamma *gamma = kzalloc(sizeof(*gamma), GFP_KERNEL);
>   
> @@ -175,7 +175,7 @@ void dc_transfer_func_release(struct dc_transfer_func *tf)
>   	kref_put(&tf->refcount, dc_transfer_func_free);
>   }
>   
> -struct dc_transfer_func *dc_create_transfer_func()
> +struct dc_transfer_func *dc_create_transfer_func(void)
>   {
>   	struct dc_transfer_func *tf = kzalloc(sizeof(*tf), GFP_KERNEL);
>   




More information about the amd-gfx mailing list