[PATCH] drm/amdgpu:fix virtual dce bug

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Wednesday, November 15, 2017 4:11 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH] drm/amdgpu:fix virtual dce bug
> 
> this fix the issue that access memory after freed
> after driver unloaded.
> 
> Change-Id: I64e2488c18f5dc044b57c74567785da21fc028da
> Signed-off-by: Monk Liu <Monk.Liu at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> index a8829af..39460eb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> @@ -437,6 +437,8 @@ static int dce_virtual_sw_fini(void *handle)
>  	drm_kms_helper_poll_fini(adev->ddev);
> 
>  	drm_mode_config_cleanup(adev->ddev);
> +	/* clear crtcs pointer to avoid dce irq finish routine access freed data
> */
> +	memset(adev->mode_info.crtcs, 0, sizeof(adev-
> >mode_info.crtcs[0]) * AMDGPU_MAX_CRTCS);
>  	adev->mode_info.mode_config_initialized = false;
>  	return 0;
>  }
> @@ -723,7 +725,7 @@ static void
> dce_virtual_set_crtc_vblank_interrupt_state(struct amdgpu_device *ad
>  							int crtc,
>  							enum
> amdgpu_interrupt_state state)
>  {
> -	if (crtc >= adev->mode_info.num_crtc) {
> +	if (crtc >= adev->mode_info.num_crtc || !adev-
> >mode_info.crtcs[crtc]) {
>  		DRM_DEBUG("invalid crtc %d\n", crtc);
>  		return;
>  	}
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx