[PATCH 2/3] drm/amd/include:cleanup vega10 hdp header files.

Alex Deucher alexdeucher at gmail.com
Thu Nov 16 14:59:29 UTC 2017


On Thu, Nov 16, 2017 at 3:03 AM, Feifei Xu <Feifei.Xu at amd.com> wrote:
> Cleanup asic_reg/vega10/HDP folder, remove hdp_4_0_default.h
>
> Change-Id: Ia7cd2e660ceb89a1096c195c6a67677714ccbd69
> Signed-off-by: Feifei Xu <Feifei.Xu at amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c              |   2 +-
>  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c              |   4 +-
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c             |   2 +-
>  drivers/gpu/drm/amd/amdgpu/soc15.c                 |   4 +-
>  drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c              |   2 +-
>  drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c              |   2 +-
>  .../drm/amd/include/asic_reg/hdp/hdp_4_0_offset.h  | 209 +++++++
>  .../drm/amd/include/asic_reg/hdp/hdp_4_0_sh_mask.h | 601 +++++++++++++++++++++
>  .../include/asic_reg/vega10/HDP/hdp_4_0_default.h  | 117 ----
>  .../include/asic_reg/vega10/HDP/hdp_4_0_offset.h   | 209 -------
>  .../include/asic_reg/vega10/HDP/hdp_4_0_sh_mask.h  | 601 ---------------------
>  11 files changed, 818 insertions(+), 935 deletions(-)
>  create mode 100644 drivers/gpu/drm/amd/include/asic_reg/hdp/hdp_4_0_offset.h
>  create mode 100644 drivers/gpu/drm/amd/include/asic_reg/hdp/hdp_4_0_sh_mask.h
>  delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/vega10/HDP/hdp_4_0_default.h
>  delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/vega10/HDP/hdp_4_0_offset.h
>  delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/vega10/HDP/hdp_4_0_sh_mask.h

Is there a reason to remove hdp_4_0_default.h?  It's useful if we ever
need to get the default values of the registers.  I think we should
try and keep the register headers consistent.  If we aren't using any
of the default headers, that's fine, we can remove them.

Alex


More information about the amd-gfx mailing list