[PATCH 3/4] drm/amdgpu: align GTT start to 4GB

Alex Deucher alexdeucher at gmail.com
Fri Nov 17 15:54:57 UTC 2017


On Fri, Nov 17, 2017 at 5:12 AM, Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
> For VCE to work properly the start of the GTT space must be aligned to a
> 4GB boundary.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index f9bee76e7071..bbaab31218a8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -622,7 +622,7 @@ void amdgpu_gart_location(struct amdgpu_device *adev, struct amdgpu_mc *mc)
>                         dev_warn(adev->dev, "limiting GTT\n");
>                         mc->gart_size = size_af;
>                 }
> -               mc->gart_start = mc->vram_end + 1;
> +               mc->gart_start = ALIGN(mc->vram_end + 1, 0x100000000ULL);

Please add a comment here as to why we are doing this.  With that fixed:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>


>         }
>         mc->gart_end = mc->gart_start + mc->gart_size - 1;
>         dev_info(adev->dev, "GTT: %lluM 0x%016llX - 0x%016llX\n",
> --
> 2.11.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list