[PATCH 1/4] drm/amdkfd: Cleanup qpd.pqm initialization

Oded Gabbay oded.gabbay at gmail.com
Sun Nov 19 13:20:29 UTC 2017


On Tue, Nov 14, 2017 at 11:41 PM, Felix Kuehling <Felix.Kuehling at amd.com> wrote:
> The PQM doesn't change after process creation. So initialize it in
> kfd_create_process_device_data.
>
> Signed-off-by: Felix Kuehling <Felix.Kuehling at amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_process.c               | 1 +
>  drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 4 +---
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 1f5ccd28..1bb9b26 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -348,6 +348,7 @@ struct kfd_process_device *kfd_create_process_device_data(struct kfd_dev *dev,
>                 INIT_LIST_HEAD(&pdd->qpd.queues_list);
>                 INIT_LIST_HEAD(&pdd->qpd.priv_queue_list);
>                 pdd->qpd.dqm = dev->dqm;
> +               pdd->qpd.pqm = &p->pqm;
>                 pdd->process = p;
>                 pdd->bound = PDD_UNBOUND;
>                 pdd->already_dequeued = false;
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> index a3f1e62..eeb7726 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
> @@ -178,10 +178,8 @@ int pqm_create_queue(struct process_queue_manager *pqm,
>                 return retval;
>
>         if (list_empty(&pdd->qpd.queues_list) &&
> -           list_empty(&pdd->qpd.priv_queue_list)) {
> -               pdd->qpd.pqm = pqm;
> +           list_empty(&pdd->qpd.priv_queue_list))
>                 dev->dqm->ops.register_process(dev->dqm, &pdd->qpd);
> -       }
>
>         pqn = kzalloc(sizeof(*pqn), GFP_KERNEL);
>         if (!pqn) {
> --
> 2.7.4
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay at gmail.com>


More information about the amd-gfx mailing list