[amd-staging-drm-next] regression - no fan info (sensors) on RX580

[Alex Deucher]

On Sun, Oct 8, 2017 at 10:31 PM, Dieter Nützel <Dieter at nuetzel-hh.de> wrote:
> OK, got it but can't revert the commit clean.
>
> amdgpu-pci-0100
> Adapter: PCI adapter
> fan1:         873 RPM
> temp1:        +26.0°C  (crit =  +0.0°C, hyst =  +0.0°C)
>
> SOURCE/amd-staging-drm-next> git bisect good
> 0944c350c8eddf4064e7abb881dd245032fdfa23 is the first bad commit
> commit 0944c350c8eddf4064e7abb881dd245032fdfa23
> Author: Rex Zhu <Rex.Zhu at amd.com>
> Date:   Mon Sep 25 18:51:50 2017 +0800
>
>     drm/amdgpu: delete pp_enable in adev
>
>     amdgpu not care powerplay or dpm is enabled.
>     just check ip functions and pp functions
>
>     Change-Id: Iaac75d45170ef9b20e212465f837eaaa798365bd
>     Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>     Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
>
> :040000 040000 72361654709479890586e383ec73088e535a1cf5
> 2b6d5a75ffc3b6fd48c63e79bf28faddcc734918 M drivers

I think the attached patch should fix it.

Alex

>
> Greetings,
> Dieter
>
>
>
> Am 09.10.2017 02:19, schrieb Dieter Nützel:
>>
>> Sorry Rex,
>>
>> after return from our vacation,
>> I've tested latest amd-staging-drm-next (e5f6a57e350a)
>> but it is NOT solved on my RX580.
>> I'll try bisecting if I find some more time in the coming days.
>>
>> amdgpu-pci-0100
>> Adapter: PCI adapter
>> temp1:        +27.0°C  (crit =  +0.0°C, hyst =  +0.0°C)
>>
>> 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc.
>> [AMD/ATI] Ellesmere [Radeon RX 470/480/570/580] (rev e7) (prog-if 00
>> [VGA controller])
>>         Subsystem: Sapphire Technology Limited Radeon RX 570
>>
>> [    36.740] (--) AMDGPU(0): Chipset: "Radeon RX 580 Series" (ChipID =
>> 0x67df)
>>
>> Thanks,
>> Dieter
>>
>> Am 30.09.2017 05:09, schrieb Zhu, Rex:
>>>
>>> Yes, caused by the commit e37a7b4088da
>>> ("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c")
>>>
>>> Replace error when split patches.
>>>
>>> Have sent the fix patch.
>>> Please review.
>>>
>>> Best Regards
>>> Rex
>>>
>>>
>>> -----Original Message-----
>>> From: Alex Deucher [mailto:alexdeucher at gmail.com]
>>> Sent: Friday, September 29, 2017 10:11 PM
>>> To: Dieter Nützel; Zhu, Rex
>>> Cc: amd-devel; DRI Devel; Wentland, Harry; Michel Dänzer
>>> Subject: Re: [amd-staging-drm-next] regression - no fan info (sensors) on
>>> RX580
>>>
>>> Rex, probably related to the recent cleanups in powerplay.
>>>
>>> On Fri, Sep 29, 2017 at 10:09 AM, Dieter Nützel <Dieter at nuetzel-hh.de>
>>> wrote:
>>>>
>>>> Hello all,
>>>>
>>>> since latest update
>>>>
>>>> 1d7da702e70d3c27408a3bb312c71d6be9f7bebe
>>>> drm/amd/powerplay: fix spelling mistake: "dividable" -> "divisible"
>>>>
>>>> I didn't get fan info with my RX580 (Polaris21) any longer.
>>>>
>>>> Worked with this commit:
>>>>
>>>> 786df0b89fe5a0b405d4de0a1ce03003c0743ec3
>>>> drm/amd/display: fix pflip irq registor for raven
>>>>
>>>> Sorry, I do not have full time for bisect, because we are on way to
>>>> our vacation.
>>>>
>>>> Maybe in the evening (only a few commits).
>>>>
>>>> Greetings,
>>>> Dieter
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-amdgpu-don-t-skip-attributes-when-powerplay-is-e.patch
Type: text/x-patch
Size: 1249 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20171120/8921196f/attachment.bin>