Operation context for TTM

[Dieter Nützel]

Hello Christian,

your latest 'amd-staging-drm-next' commit
drm/amdgpu: fix VCE buffer placement restrictions v2
#9f896d936c9d4ea936a02d52eaeb14fdd209193b

static int amdgpu_vce_validate_bo(struct amdgpu_cs_parser *p, uint32_t 
ib_idx,
				  int lo, int hi, unsigned size, int32_t index)

[-]

return ttm_bo_validate(&bo->tbo, &bo->placement, false, false);

^^^^^^
'ttm_bo_validate' with 4 than 3 parameter clash.

drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c: In function 
‘amdgpu_vce_validate_bo’:
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:590:9: error: too many arguments 
to function ‘ttm_bo_validate’
   return ttm_bo_validate(&bo->tbo, &bo->placement, false, false);
          ^~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu.h:39:0,
                  from drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:33:
./include/drm/ttm/ttm_bo_api.h:334:5: note: declared here
  int ttm_bo_validate(struct ttm_buffer_object *bo,
      ^~~~~~~~~~~~~~~

New version comming?

Thanks,
Dieter


Am 20.11.2017 05:35, schrieb Dieter Nützel:
> For the series:
> 
> Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
> 
> on RX580
> amd-staging-drm-next 85d09ce5e5039644487e9508d6359f9f4cf64427
> 
> with glmark2, DiRT Rally and F1 2017 (radv)
> 
> Dieter
> 
> Am 17.11.2017 11:49, schrieb Christian König:
>> Hi everyone,
>> 
>> Michel already reviewed this back in April, but I didn't found time to
>> actually fully test it before now.
>> 
>> So sending this one out once more because it's an interface change
>> which affects all driver using TTM.
>> 
>> Please review and/or comment.
>> 
>> Regards,
>> Christian.
>> 
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel