[PATCH] amdgpu: Downgrade DRM_ERROR to DRM_DEBUG in amdgpu_queue_mgr_map

Deucher, Alexander Alexander.Deucher at amd.com
Tue Nov 21 17:38:30 UTC 2017


> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Tuesday, November 21, 2017 12:30 PM
> To: amd-gfx at lists.freedesktop.org
> Subject: [PATCH] amdgpu: Downgrade DRM_ERROR to DRM_DEBUG in
> amdgpu_queue_mgr_map
> 
> From: Michel Dänzer <michel.daenzer at amd.com>
> 
> Prevent buggy userspace from spamming dmesg.
> 
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_queue_mgr.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_queue_mgr.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_queue_mgr.c
> index 93d86619e802..262c1267249e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_queue_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_queue_mgr.c
> @@ -225,7 +225,7 @@ int amdgpu_queue_mgr_map(struct amdgpu_device
> *adev,
> 
>  	/* Right now all IPs have only one instance - multiple rings. */
>  	if (instance != 0) {
> -		DRM_ERROR("invalid ip instance: %d\n", instance);
> +		DRM_DEBUG("invalid ip instance: %d\n", instance);
>  		return -EINVAL;
>  	}
> 
> @@ -255,13 +255,13 @@ int amdgpu_queue_mgr_map(struct
> amdgpu_device *adev,
>  		ip_num_rings = adev->vcn.num_enc_rings;
>  		break;
>  	default:
> -		DRM_ERROR("unknown ip type: %d\n", hw_ip);
> +		DRM_DEBUG("unknown ip type: %d\n", hw_ip);
>  		return -EINVAL;
>  	}
> 
>  	if (ring >= ip_num_rings) {
> -		DRM_ERROR("Ring index:%d exceeds maximum:%d for
> ip:%d\n",
> -				ring, ip_num_rings, hw_ip);
> +		DRM_DEBUG("Ring index:%d exceeds maximum:%d for
> ip:%d\n",
> +			  ring, ip_num_rings, hw_ip);
>  		return -EINVAL;
>  	}
> 
> @@ -292,7 +292,7 @@ int amdgpu_queue_mgr_map(struct amdgpu_device
> *adev,
>  	default:
>  		*out_ring = NULL;
>  		r = -EINVAL;
> -		DRM_ERROR("unknown HW IP type: %d\n", mapper-
> >hw_ip);
> +		DRM_DEBUG("unknown HW IP type: %d\n", mapper-
> >hw_ip);
>  	}
> 
>  out_unlock:
> --
> 2.15.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list