[PATCH] amdgpu: Use unsigned HW IP/instance/ring indices in amdgpu_queue_mgr_map

Michel Dänzer michel at daenzer.net
Wed Nov 22 09:32:08 UTC 2017

On 2017-11-22 10:22 AM, Christian König wrote:
> Am 22.11.2017 um 09:42 schrieb Michel Dänzer:
>> On 2017-11-21 07:38 PM, Christian König wrote:
>>> Am 21.11.2017 um 18:29 schrieb Michel Dänzer:
>>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>> This matches the corresponding UAPI fields. Treating the ring index as
>>>> signed could result in accessing random unrelated memory if the MSB was
>>>> set.
>>>> Fixes: effd924d2f3b ("drm/amdgpu: untie user ring ids from kernel ring
>>>>                         ids v6")
>>>> Cc: stable at vger.kernel.org
>>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>>> Subject line is off, [...]
>> I assume you're referring to the prefix. Well, I'm actually trying to
>> set a trend there. :) Since there's no other amdgpu driver, the drm/ is
>> redundant. In the specific case of this patch, adding it would make the
>> shortlog too long, and IME it's quite often the case that those four
>> character cells could be put to better use than for the redundant prefix.
> Yeah, making the prefix shorter is one thing I have thought about as well.
> But currently we use "drm/amdgpu:" for the kernel and "amdgpu:" for
> libdrm and I actually would like to keep that.

libdrm patches should have [PATCH libdrm] .

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the amd-gfx mailing list