[PATCH libdrm] [drm] - Adding amdgpu_cs_create_syncobj2 to create syncobj as signaled initially

[Marek Olšák]

You need a freedesktop.org account:
https://www.freedesktop.org/wiki/AccountRequests/

Marek

On Tue, Nov 28, 2017 at 2:32 PM, Mao, David <David.Mao at amd.com> wrote:
> I have never tried to commit the change before. So I guess the answer is no.
> Could you let me know, how I can apply for the commit right?
>
> Thanks.
> Best Regards,
> David
>
> -----Original Message-----
> From: Christian König [mailto:ckoenig.leichtzumerken at gmail.com]
> Sent: Tuesday, November 28, 2017 9:29 PM
> To: Mao, David <David.Mao at amd.com>; amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH libdrm] [drm] - Adding amdgpu_cs_create_syncobj2 to create syncobj as signaled initially
>
> Reviewed-by: Christian König <christian.koenig at amd.com>
>
> But in general for libdrm changes I would ping Marek, Nicolai, Michel and in this special case Dave Airlie because he added the patch with the missing flags field.
>
> And I strongly assume you don't have commit rights, don't you?
>
> Regards,
> Christian.
>
> Am 28.11.2017 um 14:22 schrieb Mao, David:
>> Anyone can help to review the change?
>> Thanks.
>>
>> Best Regards,
>> David
>>
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
>> Of David Mao
>> Sent: Tuesday, November 28, 2017 11:26 AM
>> To: amd-gfx at lists.freedesktop.org
>> Subject: [PATCH libdrm] [drm] - Adding amdgpu_cs_create_syncobj2 to
>> create syncobj as signaled initially
>>
>> Change-Id: Icf8d29bd4b50ee76936faacbbe099492cf0557cc
>> Signed-off-by: David Mao <david.mao at amd.com>
>> ---
>>   amdgpu/amdgpu.h    | 15 +++++++++++++++
>>   amdgpu/amdgpu_cs.c | 10 ++++++++++
>>   2 files changed, 25 insertions(+)
>>
>> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 78fbd1e..47bdb3a
>> 100644
>> --- a/amdgpu/amdgpu.h
>> +++ b/amdgpu/amdgpu.h
>> @@ -1727,6 +1727,21 @@ const char *amdgpu_get_marketing_name(amdgpu_device_handle dev);
>>   /**
>>    *  Create kernel sync object
>>    *
>> + * \param   dev         - \c [in]  device handle
>> + * \param   flags       - \c [in]  flags that affect creation
>> + * \param   syncobj     - \c [out] sync object handle
>> + *
>> + * \return   0 on success\n
>> + *          <0 - Negative POSIX Error code
>> + *
>> +*/
>> +int amdgpu_cs_create_syncobj2(amdgpu_device_handle dev,
>> +                           uint32_t  flags,
>> +                           uint32_t *syncobj);
>> +
>> +/**
>> + *  Create kernel sync object
>> + *
>>    * \param   dev           - \c [in]  device handle
>>    * \param   syncobj   - \c [out] sync object handle
>>    *
>> diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c index
>> 64ad911..a9fbab9 100644
>> --- a/amdgpu/amdgpu_cs.c
>> +++ b/amdgpu/amdgpu_cs.c
>> @@ -606,6 +606,16 @@ int amdgpu_cs_destroy_semaphore(amdgpu_semaphore_handle sem)
>>       return amdgpu_cs_unreference_sem(sem);  }
>>
>> +int amdgpu_cs_create_syncobj2(amdgpu_device_handle dev,
>> +                           uint32_t  flags,
>> +                           uint32_t *handle)
>> +{
>> +     if (NULL == dev)
>> +             return -EINVAL;
>> +
>> +     return drmSyncobjCreate(dev->fd, flags, handle); }
>> +
>>   int amdgpu_cs_create_syncobj(amdgpu_device_handle dev,
>>                            uint32_t *handle)
>>   {
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx