regression on suspend/resume for Carrizo

Leo sunpeng.li at amd.com
Fri Oct 13 14:53:55 UTC 2017


Hi Tom,

This is a known issue, and we're currently tracking it on ticket
SWDEV-135329. It's reported using Vega10, but we reproduced it on
Carrizo as well.

Thanks,
Leo

On 2017-10-13 09:30 AM, Tom St Denis wrote:
> For what it's worth this commit also breaks resume on my Tonga only 
> system so it's not specific to just Carrizo.
> 
> On 13/10/17 08:16 AM, Tom St Denis wrote:
>> Hi,
>>
>> This commit breaks suspend/resume on my Carrizo A12-9800 system.
>>
>> [root at carrizo linux2]# git bisect bad
>> 7ae4acd21e9e264afb079e23d43bcf2238c7dbea is the first bad commit
>> commit 7ae4acd21e9e264afb079e23d43bcf2238c7dbea
>> Author: Leo (Sunpeng) Li <sunpeng.li at amd.com>
>> Date:   Thu Sep 7 17:05:38 2017 -0400
>>
>>      drm/amd/display: Match actual state during S3 resume.
>>
>>      During system suspend, we:
>>
>>      1. Cache a duplicate of the current DRM atomic state, which calls 
>> hooks
>>         to duplicate our internal states.
>>      2. Call hooks to disable all functionalities.
>>      3. System suspended.
>>
>>      During resume, we attempt to restore the cached state. However, our
>>      interal states are now stale, since step 1 was done before step 2.
>>      i.e. our cached state does not reflect the disabled nature of 
>> things.
>>
>>      This change resolves that by destroying all relevant states to 
>> reflect
>>      the actual state during resume.
>>
>>      Signed-off-by: Leo (Sunpeng) Li <sunpeng.li at amd.com>
>>      Reviewed-by: Harry Wentland <Harry.Wentland at amd.com>
>>
>> Tom
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list