[PATCH v2] drm/amd/display: Fix warning about overflow

Deucher, Alexander Alexander.Deucher at amd.com
Fri Oct 13 19:04:17 UTC 2017


> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Harry Wentland
> Sent: Friday, October 13, 2017 3:03 PM
> To: amd-gfx at lists.freedesktop.org; michel at daenzer.net; Daenzer, Michel;
> Koenig, Christian
> Cc: Wentland, Harry
> Subject: [PATCH v2] drm/amd/display: Fix warning about overflow
> 
> v2: convert value to bool using !!
> 
> Signed-off-by: Harry Wentland <harry.wentland at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> index cb94e18cc455..43e9a9959288 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> @@ -1042,13 +1042,13 @@ static enum bp_result
> get_embedded_panel_info_v2_1(
>  	info->lcd_timing.misc_info.VERTICAL_CUT_OFF = 0;
> 
>  	info->lcd_timing.misc_info.H_REPLICATION_BY2 =
> -		lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2;
> +		!!(lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2);
>  	info->lcd_timing.misc_info.V_REPLICATION_BY2 =
> -		lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2;
> +		!!(lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2);
>  	info->lcd_timing.misc_info.COMPOSITE_SYNC =
> -		lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC;
> +		!!(lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC);
>  	info->lcd_timing.misc_info.INTERLACE =
> -		lvds->lcd_timing.miscinfo & ATOM_INTERLACE;
> +		!!(lvds->lcd_timing.miscinfo & ATOM_INTERLACE);
> 
>  	/* not provided by VBIOS*/
>  	info->lcd_timing.misc_info.DOUBLE_CLOCK = 0;
> @@ -1056,7 +1056,7 @@ static enum bp_result
> get_embedded_panel_info_v2_1(
>  	info->ss_id = 0;
> 
>  	info->realtek_eDPToLVDS =
> -			(lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID ?
> 1:0);
> +			!!(lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID);
> 
>  	return BP_RESULT_OK;
>  }
> --
> 2.14.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list