[PATCH 7/7] drm/amd/powerplay: Tidy up cz_dpm_powerup_vce()
Deucher, Alexander
Alexander.Deucher at amd.com
Mon Oct 16 18:30:43 UTC 2017
> -----Original Message-----
> From: StDenis, Tom
> Sent: Monday, October 16, 2017 2:25 PM
> To: Deucher, Alexander; amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH 7/7] drm/amd/powerplay: Tidy up
> cz_dpm_powerup_vce()
>
> On 16/10/17 02:23 PM, Deucher, Alexander wrote:
> >> -----Original Message-----
> >> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On
> Behalf
> >> Of Tom St Denis
> >> Sent: Monday, October 16, 2017 1:55 PM
> >> To: amd-gfx at lists.freedesktop.org
> >> Cc: StDenis, Tom
> >> Subject: [PATCH 7/7] drm/amd/powerplay: Tidy up
> cz_dpm_powerup_vce()
> >>
> >> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
> >> ---
> >> drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 5 ++---
> >> 1 file changed, 2 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c
> >> b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c
> >> index 23df056a034b..ca06033cd155 100644
> >> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c
> >> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c
> >> @@ -1370,10 +1370,9 @@ int cz_dpm_powerdown_vce(struct pp_hwmgr
> >> *hwmgr)
> >>
> >> int cz_dpm_powerup_vce(struct pp_hwmgr *hwmgr)
> >> {
> >> - if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps,
> >> -
> >> PHM_PlatformCaps_VCEPowerGating))
> >> + if (PP_CAP(PHM_PlatformCaps_VCEPowerGating))
> >> return smum_send_msg_to_smc(hwmgr,
> >> -
> >> PPSMC_MSG_VCEPowerON);
> >> + PPSMC_MSG_VCEPowerON);
> >
> > Same here (indentation looked correct before).
>
> I was simply trying to make the lines a bit narrower. (while using the
> PP_CAP macro).
>
> I can drop that part of the commits if you want.
Please. Thanks! With that fixed and the commit messages updates, patches 6 and 7 are:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
Alex
More information about the amd-gfx
mailing list