[PATCH] drm/amd/pp: thermal control not enabled on vega10.

Deucher, Alexander Alexander.Deucher at amd.com
Wed Oct 18 14:01:13 UTC 2017


> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Rex Zhu
> Sent: Wednesday, October 18, 2017 2:36 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH] drm/amd/pp: thermal control not enabled on vega10.
> 
> regresstion issue.
> caused by "f12f9f5e5d455edebc01"
> forget to set start_thermal_controller function point.
> 
> Change-Id: Idcb127daccb96a6b30f8f83e8b1bd65b8f872f55
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c   | 1 +
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 04666d2..48e1d65 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -5108,6 +5108,7 @@ static int vega10_register_thermal_interrupt(struct
> pp_hwmgr *hwmgr,
>  	.avfs_control = vega10_avfs_enable,
>  	.notify_cac_buffer_info = vega10_notify_cac_buffer_info,
>  	.register_internal_thermal_interrupt =
> vega10_register_thermal_interrupt,
> +	.start_thermal_controller = vega10_start_thermal_controller,
>  };
> 
>  int vega10_hwmgr_init(struct pp_hwmgr *hwmgr)
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h
> index f34ce04..82f10bd 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.h
> @@ -71,7 +71,8 @@ extern int vega10_fan_ctrl_get_fan_speed_rpm(struct
> pp_hwmgr *hwmgr,
>  extern int vega10_fan_ctrl_stop_smc_fan_control(struct pp_hwmgr
> *hwmgr);
>  extern int vega10_thermal_disable_alert(struct pp_hwmgr *hwmgr);
>  extern int vega10_fan_ctrl_start_smc_fan_control(struct pp_hwmgr
> *hwmgr);
> -
> +extern int vega10_start_thermal_controller(struct pp_hwmgr *hwmgr,
> +				struct PP_TemperatureRange *range);
>  extern uint32_t smu7_get_xclk(struct pp_hwmgr *hwmgr);
> 
>  #endif
> --
> 1.9.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list