[PATCH 2/2] drm/amd/powerplay: fix uninitialized variable

[Alex Deucher]

On Fri, Oct 20, 2017 at 3:21 AM, Rex Zhu <Rex.Zhu at amd.com> wrote:
> refresh_rate was not initialized when program
> display gap.
> this patch can fix vce ring test failed
> when do S3 on Polaris10.
>
> Change-Id: Ie7bb363a44df0ea5dca3c03b8d884ac42a5db0a7
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index e32f18a..4466469 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -815,7 +815,7 @@ uint32_t smu7_get_xclk(struct pp_hwmgr *hwmgr)
>  {
>         uint32_t reference_clock, tmp;
>         struct cgs_display_info info = {0};
> -       struct cgs_mode_info mode_info;
> +       struct cgs_mode_info mode_info = {0};
>
>         info.mode_info = &mode_info;
>
> @@ -3948,10 +3948,9 @@ static int smu7_program_display_gap(struct pp_hwmgr *hwmgr)
>         uint32_t ref_clock;
>         uint32_t refresh_rate = 0;
>         struct cgs_display_info info = {0};
> -       struct cgs_mode_info mode_info;
> +       struct cgs_mode_info mode_info = {0};
>
>         info.mode_info = &mode_info;
> -
>         cgs_get_active_displays_info(hwmgr->device, &info);
>         num_active_displays = info.display_count;
>
> @@ -3967,6 +3966,7 @@ static int smu7_program_display_gap(struct pp_hwmgr *hwmgr)
>         frame_time_in_us = 1000000 / refresh_rate;
>
>         pre_vbi_time_in_us = frame_time_in_us - 200 - mode_info.vblank_time_us;
> +
>         data->frame_time_x2 = frame_time_in_us * 2 / 100;
>
>         display_gap2 = pre_vbi_time_in_us * (ref_clock / 100);
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx