[PATCH] drm/amd/display: assign fb_location only if bo is pinned

Michel Dänzer michel at daenzer.net
Wed Oct 25 08:08:07 UTC 2017

On 25/10/17 07:18 AM, S, Shirish wrote:
> Andrey,
> Till now the get_fb_info() never calculated fb_location(as addrReq was
> always false), but since now its required to program the high part of
> the address structure,
> can you move it back into the commit scope and ensure that fb_location
> is calculated everytime.(I have limited knowledge behind why it was
> moved out)
> And in case if you insist on adding pin & unpin in atomic_check() scope
> i can post a patch for it.

The latter on its own couldn't really solve the problem anyway: While a
BO is unpinned, its MC address can change at any time. The MC address
programmed to the hardware must be determined while the BO is and stays

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the amd-gfx mailing list