[PATCH 15/16] drm/amdkfd: wait only for IH work on IH exit
Oded Gabbay
oded.gabbay at gmail.com
Wed Oct 25 12:20:13 UTC 2017
On Sat, Oct 21, 2017 at 3:23 AM, Felix Kuehling <Felix.Kuehling at amd.com> wrote:
> From: Andres Rodriguez <andres.rodriguez at amd.com>
>
> We don't need to wait for all work to complete in the IH exit function.
> We only need to make sure the interrupt_work has finished executing to
> guarantee that ih_kfifo is no longer in use.
>
> Signed-off-by: Andres Rodriguez <andres.rodriguez at amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> index a147269..9c08d46 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> @@ -91,11 +91,11 @@ void kfd_interrupt_exit(struct kfd_dev *kfd)
> spin_unlock_irqrestore(&kfd->interrupt_lock, flags);
>
> /*
> - * Flush_scheduled_work ensures that there are no outstanding
> + * flush_work ensures that there are no outstanding
> * work-queue items that will access interrupt_ring. New work items
> * can't be created because we stopped interrupt handling above.
> */
> - flush_scheduled_work();
> + flush_work(&kfd->interrupt_work);
>
> kfifo_free(&kfd->ih_fifo);
> }
> --
> 2.7.4
>
This patch is:
Acked-by: Oded Gabbay <oded.gabbay at gmail.com>
More information about the amd-gfx
mailing list