[PATCH 4/8] drm/amdgpu: don't wait interruptible while binding GART space

[Christian König]

Am 26.10.2017 um 19:56 schrieb Deucher, Alexander:
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
>> Of Christian König
>> Sent: Thursday, October 26, 2017 12:06 PM
>> To: amd-gfx at lists.freedesktop.org
>> Subject: [PATCH 4/8] drm/amdgpu: don't wait interruptible while binding
>> GART space
>>
>> From: Christian König <christian.koenig at amd.com>
>>
>> Display can't seem to handle this correctly.
>>
>> Signed-off-by: Christian König <christian.koenig at amd.com>
> Acked-by: Alex Deucher <alexander.deucher at amd.com>

BTW: Harry & Andrey:

It is probably a good idea to actually wait interruptible here.

How problematic would it be for you guys to allow that?

The only negative effect I could find of hand is some error printing in 
the DC code.

Christian.

>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> index e5cab4b..3045701 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> @@ -913,7 +913,7 @@ int amdgpu_ttm_bind(struct ttm_buffer_object *bo,
>> struct ttm_mem_reg *bo_mem)
>>   	placements.flags = (bo->mem.placement & ~TTM_PL_MASK_MEM)
>> |
>>   		TTM_PL_FLAG_TT;
>>
>> -	r = ttm_bo_mem_space(bo, &placement, &tmp, true, false);
>> +	r = ttm_bo_mem_space(bo, &placement, &tmp, false, false);
>>   	if (unlikely(r))
>>   		return r;
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx