[PATCH] drm/ttm: fix memory leak while individualizing BOs

Liu, Monk Monk.Liu at amd.com
Wed Sep 13 09:30:25 UTC 2017


verified work,


Reviewed-by: Monk Liu <monk.liu at amd.com>

________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Christian König <deathsimple at vodafone.de>
Sent: Wednesday, September 13, 2017 4:47:34 PM
To: amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
Subject: [PATCH] drm/ttm: fix memory leak while individualizing BOs

From: Christian König <christian.koenig at amd.com>

We need to free the reservation object before we take the BO
from the delayed delete list.

Signed-off-by: Christian König <christian.koenig at amd.com>
---
 drivers/gpu/drm/ttm/ttm_bo.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index bee77d3..d79607a 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -557,6 +557,8 @@ static int ttm_bo_cleanup_refs_and_unlock(struct ttm_buffer_object *bo,
         }

         ttm_bo_del_from_lru(bo);
+       if (!list_empty(&bo->ddestroy) && (bo->resv != &bo->ttm_resv))
+               reservation_object_fini(&bo->ttm_resv);
         list_del_init(&bo->ddestroy);
         kref_put(&bo->list_kref, ttm_bo_ref_bug);

--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170913/a797a282/attachment-0001.html>


More information about the amd-gfx mailing list