[PATCH] drm/amdgpu: fix checkpatch.pl error to amdgpu_drv.c

Christian König ckoenig.leichtzumerken at gmail.com
Fri Sep 15 12:18:51 UTC 2017


Am 15.09.2017 um 13:58 schrieb Rex Zhu:
> fix checkpatch.pl error and warning:
> 1. ERROR: do not initialise globals to NULL
> 2. ERROR: do not initialise globals to 0
> 3. WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Change-Id: I7029087efcfa88c968be9d7ae42f2453bc4b1da0
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

Amdgpu has used "unsigned" quite extensively, but yeah in theory we 
should fix that sooner or later.

Patch is Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h     | 14 ++++-----
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 54 ++++++++++++++++-----------------
>   2 files changed, 34 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 3cdca78..3a7d32e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -93,7 +93,7 @@
>   extern int amdgpu_fw_load_type;
>   extern int amdgpu_aspm;
>   extern int amdgpu_runtime_pm;
> -extern unsigned amdgpu_ip_block_mask;
> +extern uint amdgpu_ip_block_mask;
>   extern int amdgpu_bapm;
>   extern int amdgpu_deep_color;
>   extern int amdgpu_vm_size;
> @@ -107,14 +107,14 @@
>   extern int amdgpu_sched_hw_submission;
>   extern int amdgpu_no_evict;
>   extern int amdgpu_direct_gma_size;
> -extern unsigned amdgpu_pcie_gen_cap;
> -extern unsigned amdgpu_pcie_lane_cap;
> -extern unsigned amdgpu_cg_mask;
> -extern unsigned amdgpu_pg_mask;
> -extern unsigned amdgpu_sdma_phase_quantum;
> +extern uint amdgpu_pcie_gen_cap;
> +extern uint amdgpu_pcie_lane_cap;
> +extern uint amdgpu_cg_mask;
> +extern uint amdgpu_pg_mask;
> +extern uint amdgpu_sdma_phase_quantum;
>   extern char *amdgpu_disable_cu;
>   extern char *amdgpu_virtual_display;
> -extern unsigned amdgpu_pp_feature_mask;
> +extern uint amdgpu_pp_feature_mask;
>   extern int amdgpu_vram_page_split;
>   extern int amdgpu_ngg;
>   extern int amdgpu_prim_buf_per_se;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 47e4e66..52fa8636 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -75,53 +75,53 @@
>   #define KMS_DRIVER_MINOR	20
>   #define KMS_DRIVER_PATCHLEVEL	0
>   
> -int amdgpu_vram_limit = 0;
> -int amdgpu_vis_vram_limit = 0;
> +int amdgpu_vram_limit;
> +int amdgpu_vis_vram_limit;
>   int amdgpu_gart_size = -1; /* auto */
>   int amdgpu_gtt_size = -1; /* auto */
>   int amdgpu_moverate = -1; /* auto */
> -int amdgpu_benchmarking = 0;
> -int amdgpu_testing = 0;
> +int amdgpu_benchmarking;
> +int amdgpu_testing;
>   int amdgpu_audio = -1;
> -int amdgpu_disp_priority = 0;
> +int amdgpu_disp_priority;
>   int amdgpu_hw_i2c = 0;
>   int amdgpu_pcie_gen2 = -1;
>   int amdgpu_msi = -1;
> -int amdgpu_lockup_timeout = 0;
> +int amdgpu_lockup_timeout;
>   int amdgpu_dpm = -1;
>   int amdgpu_fw_load_type = -1;
>   int amdgpu_aspm = -1;
>   int amdgpu_runtime_pm = -1;
> -unsigned amdgpu_ip_block_mask = 0xffffffff;
> +uint amdgpu_ip_block_mask = 0xffffffff;
>   int amdgpu_bapm = -1;
> -int amdgpu_deep_color = 0;
> +int amdgpu_deep_color;
>   int amdgpu_vm_size = -1;
>   int amdgpu_vm_fragment_size = -1;
>   int amdgpu_vm_block_size = -1;
> -int amdgpu_vm_fault_stop = 0;
> -int amdgpu_vm_debug = 0;
> +int amdgpu_vm_fault_stop;
> +int amdgpu_vm_debug;
>   int amdgpu_vram_page_split = 512;
>   int amdgpu_vm_update_mode = -1;
> -int amdgpu_exp_hw_support = 0;
> +int amdgpu_exp_hw_support;
>   int amdgpu_dc = -1;
>   int amdgpu_sched_jobs = 32;
>   int amdgpu_sched_hw_submission = 2;
> -int amdgpu_no_evict = 0;
> -int amdgpu_direct_gma_size = 0;
> -unsigned amdgpu_pcie_gen_cap = 0;
> -unsigned amdgpu_pcie_lane_cap = 0;
> -unsigned amdgpu_cg_mask = 0xffffffff;
> -unsigned amdgpu_pg_mask = 0xffffffff;
> -unsigned amdgpu_sdma_phase_quantum = 32;
> -char *amdgpu_disable_cu = NULL;
> -char *amdgpu_virtual_display = NULL;
> -unsigned amdgpu_pp_feature_mask = 0xffffffff;
> -int amdgpu_ngg = 0;
> -int amdgpu_prim_buf_per_se = 0;
> -int amdgpu_pos_buf_per_se = 0;
> -int amdgpu_cntl_sb_buf_per_se = 0;
> -int amdgpu_param_buf_per_se = 0;
> -int amdgpu_job_hang_limit = 0;
> +int amdgpu_no_evict;
> +int amdgpu_direct_gma_size;
> +uint amdgpu_pcie_gen_cap;
> +uint amdgpu_pcie_lane_cap;
> +uint amdgpu_cg_mask = 0xffffffff;
> +uint amdgpu_pg_mask = 0xffffffff;
> +uint amdgpu_sdma_phase_quantum = 32;
> +char *amdgpu_disable_cu;
> +char *amdgpu_virtual_display;
> +uint amdgpu_pp_feature_mask = 0xffffffff;
> +int amdgpu_ngg;
> +int amdgpu_prim_buf_per_se;
> +int amdgpu_pos_buf_per_se;
> +int amdgpu_cntl_sb_buf_per_se;
> +int amdgpu_param_buf_per_se;
> +int amdgpu_job_hang_limit;
>   int amdgpu_lbpw = -1;
>   uint amdgpu_smu_memory_pool_size;
>   




More information about the amd-gfx mailing list