[PATCH] drm/amdgpu: Fix driver reloading failure

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Xiangliang.Yu
> Sent: Wednesday, September 20, 2017 11:22 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Yu, Xiangliang
> Subject: [PATCH] drm/amdgpu: Fix driver reloading failure
> 
> SRIOV doesn't implement PMC capability of PCIe, so it can't update
> power state by reading PMC register.
> 
> Currently, amdgpu driver doesn't disable pci device when removing
> driver, the enable_cnt of pci device will not be decrease to 0.
> When reloading driver, pci_enable_device will do nothing as
> enable_cnt is not zero. And power state will not be updated as PMC
> is not support.
> So current_state of pci device is not D0 state and pci_enable_msi
> return fail.
> 
> Add pci_disable_device when remmoving driver to fix the issue.
> 
> Signed-off-by: Xiangliang.Yu <Xiangliang.Yu at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 5035305c..f7b3acb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -613,6 +613,8 @@ amdgpu_pci_remove(struct pci_dev *pdev)
> 
>  	drm_dev_unregister(dev);
>  	drm_dev_unref(dev);
> +	pci_disable_device(pdev);
> +	pci_set_drvdata(pdev, NULL);
>  }
> 
>  static void
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx