[PATCH 2/4] drm/amdgpu/sriov:alloc KIQ MQD in VRAM

[Christian König]

Am 21.09.2017 um 09:12 schrieb Monk Liu:
> this way after KIQ MQD released in drv unloading, CPC
> can still let KIQ access this MQD thus RLCV SAVE_VF
> will not fail
>
> Change-Id: Iccef37a70c193c83af80961dae2c67ed859f1a13
> Signed-off-by: Monk Liu <Monk.Liu at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 4f6c68f..d85962b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -261,7 +261,7 @@ int amdgpu_gfx_compute_mqd_sw_init(struct amdgpu_device *adev,
>   	ring = &adev->gfx.kiq.ring;
>   	if (!ring->mqd_obj) {
>   		r = amdgpu_bo_create_kernel(adev, mqd_size, PAGE_SIZE,
> -					    AMDGPU_GEM_DOMAIN_GTT, &ring->mqd_obj,
> +					    (amdgpu_sriov_vf(adev) ? AMDGPU_GEM_DOMAIN_VRAM : AMDGPU_GEM_DOMAIN_GTT), &ring->mqd_obj,

Looks like that line is getting to long, please wrap it a bit.

Apart from that the series looks good to me, but I don't have the 
slightest idea if that is really correct what you do with the KCQ.

Patch #3 is Reviewed-by: Christian König <christian.koenig at amd.com>, the 
rest is Acked-by: Christian König <christian.koenig at amd.com>

Maybe wait for Alex/Felix to have another look as well.

Regards,
Christian.

>   					    &ring->mqd_gpu_addr, &ring->mqd_ptr);
>   		if (r) {
>   			dev_warn(adev->dev, "failed to create ring mqd ob (%d)", r);