[PATCH 2/4] drm/amdgpu/sriov:alloc KIQ MQD in VRAM

[Deucher, Alexander]

> -----Original Message-----
> From: Liu, Monk
> Sent: Thursday, September 21, 2017 11:37 PM
> To: Deucher, Alexander; amd-gfx at lists.freedesktop.org
> Subject: RE: [PATCH 2/4] drm/amdgpu/sriov:alloc KIQ MQD in VRAM
> 
> Alex
> 
> Since CPU visible VRAM resource is very limited, I'm not sure BM like it or
> not,
> Besides, after we unify the code we'll forget why we do this on SRIOV and in
> future someone will change it back to GTT domain (some guy care bare-
> metal only) and lead to SRIOV issues and that time it's hard to recall what's
> going on

You could add a comment.  I'm ok either way for this one.
Acked-by: Alex Deucher <alexander.deucher at amd.com>

Alex

> 
> I prefer keep things different that's good to maintain the stability
> 
> BR Monk
> 
> -----Original Message-----
> From: Deucher, Alexander
> Sent: 2017年9月21日 23:00
> To: Liu, Monk <Monk.Liu at amd.com>; amd-gfx at lists.freedesktop.org
> Cc: Liu, Monk <Monk.Liu at amd.com>
> Subject: RE: [PATCH 2/4] drm/amdgpu/sriov:alloc KIQ MQD in VRAM
> 
> > -----Original Message-----
> > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> > Of Monk Liu
> > Sent: Thursday, September 21, 2017 3:12 AM
> > To: amd-gfx at lists.freedesktop.org
> > Cc: Liu, Monk
> > Subject: [PATCH 2/4] drm/amdgpu/sriov:alloc KIQ MQD in VRAM
> >
> > this way after KIQ MQD released in drv unloading, CPC can still let
> > KIQ access this MQD thus RLCV SAVE_VF will not fail
> >
> > Change-Id: Iccef37a70c193c83af80961dae2c67ed859f1a13
> > Signed-off-by: Monk Liu <Monk.Liu at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> > index 4f6c68f..d85962b 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> > @@ -261,7 +261,7 @@ int amdgpu_gfx_compute_mqd_sw_init(struct
> > amdgpu_device *adev,
> >  	ring = &adev->gfx.kiq.ring;
> >  	if (!ring->mqd_obj) {
> >  		r = amdgpu_bo_create_kernel(adev, mqd_size, PAGE_SIZE,
> > -					    AMDGPU_GEM_DOMAIN_GTT,
> > &ring->mqd_obj,
> > +					    (amdgpu_sriov_vf(adev) ?
> > AMDGPU_GEM_DOMAIN_VRAM : AMDGPU_GEM_DOMAIN_GTT), &ring-
> 
> Here as well.  Might as well vram for both VF and bare metal for consistency.
> 
> Alex
> 
> > >mqd_obj,
> >  					    &ring->mqd_gpu_addr, &ring-
> > >mqd_ptr);
> >  		if (r) {
> >  			dev_warn(adev->dev, "failed to create ring mqd ob
> (%d)", r);
> > --
> > 2.7.4
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx