[PATCH] amdgpu/pp: move PhwVega10_Magic to static const.

Alex Deucher alexdeucher at gmail.com
Thu Sep 28 18:52:09 UTC 2017


On Wed, Sep 27, 2017 at 7:33 PM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This isn't used outside this file.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +-
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 80e41be..71b9424 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -81,7 +81,7 @@ static const uint32_t channel_number[] = {1, 2, 0, 4, 0, 8, 0, 16, 2};
>  static int vega10_force_clock_level(struct pp_hwmgr *hwmgr,
>                 enum pp_clock_type type, uint32_t mask);
>
> -const ULONG PhwVega10_Magic = (ULONG)(PHM_VIslands_Magic);
> +static const ULONG PhwVega10_Magic = (ULONG)(PHM_VIslands_Magic);
>
>  struct vega10_power_state *cast_phw_vega10_power_state(
>                                   struct pp_hw_power_state *hw_ps)
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.h b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.h
> index 676cd77..b4b461c3 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.h
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.h
> @@ -31,7 +31,6 @@
>  #include "vega10_ppsmc.h"
>  #include "vega10_powertune.h"
>
> -extern const uint32_t PhwVega10_Magic;
>  #define VEGA10_MAX_HARDWARE_POWERLEVELS 2
>
>  #define WaterMarksExist  1
> --
> 2.9.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list