[PATCH 32/32] drm/amd/display: Fix dim display on DCE11

Michel Dänzer michel at daenzer.net
Wed Apr 4 07:18:28 UTC 2018


On 2018-04-04 03:27 AM, Harry Wentland wrote:
> From: "Leo (Sunpeng) Li" <sunpeng.li at amd.com>
> 
> Before programming the input gamma, check that we're not using the
> identity correction.
> 
> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li at amd.com>
> Reviewed-by: Anthony Koo <Anthony.Koo at amd.com>
> Acked-by: Harry Wentland <harry.wentland at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 99d192200797..f385b18d5c2e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -280,7 +280,9 @@ dce110_set_input_transfer_func(struct pipe_ctx *pipe_ctx,
>  	build_prescale_params(&prescale_params, plane_state);
>  	ipp->funcs->ipp_program_prescale(ipp, &prescale_params);
>  
> -	if (plane_state->gamma_correction && dce_use_lut(plane_state->format))
> +	if (plane_state->gamma_correction &&
> +			!plane_state->gamma_correction->is_identity &&
> +			dce_use_lut(plane_state->format))

The second and third line of the if condition are indented incorrectly,
should be one tab and 4 spaces to align with the opening parenthesis.

There are similar issues in other patches as well. Make sure your
editors are configured correctly for the Linux kernel coding style.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list