[PATCH xf86-video-amdgpu 11/19] Don't leak a AMDGPUEntRec instance if amdgpu_device_setup fails

Emil Velikov emil.l.velikov at gmail.com
Wed Apr 4 14:29:46 UTC 2018


From: Emil Velikov <emil.velikov at collabora.com>

Seems like we've been leaking this for years. It became more obvious
with the recent refactoring.

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
 src/amdgpu_probe.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/amdgpu_probe.c b/src/amdgpu_probe.c
index 537d44c..588891c 100644
--- a/src/amdgpu_probe.c
+++ b/src/amdgpu_probe.c
@@ -243,6 +243,8 @@ amdgpu_probe(ScrnInfoPtr pScrn, int entity_num,
 	return TRUE;
 
 error:
+	free(pPriv->ptr);
+	pPriv->ptr = NULL;
 	return FALSE;
 }
 
-- 
2.16.0



More information about the amd-gfx mailing list