[PATCH xf86-video-amdgpu 14/19] Do not export gAMDGPUEntityIndex

Emil Velikov emil.l.velikov at gmail.com
Wed Apr 4 14:29:49 UTC 2018


From: Emil Velikov <emil.velikov at collabora.com>

The modules should not export anything but a single *ModuleData symbol.
Seemingly a copy/paste mistake from the radeon driver.

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
I'm aroung 70% sure on this one.

Yet again, perhaps multi GPU setups do - somehow pulling the _X_EXPORT
variable over the local one? I seriously doubt it though.
---
 src/amdgpu_kms.c   | 2 +-
 src/amdgpu_probe.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
index 2ee7007..5d85bd7 100644
--- a/src/amdgpu_kms.c
+++ b/src/amdgpu_kms.c
@@ -87,7 +87,7 @@ const OptionInfoRec *AMDGPUOptionsWeak(void)
 	return AMDGPUOptions_KMS;
 }
 
-extern _X_EXPORT int gAMDGPUEntityIndex;
+extern int gAMDGPUEntityIndex;
 
 static int getAMDGPUEntityIndex(void)
 {
diff --git a/src/amdgpu_probe.c b/src/amdgpu_probe.c
index 588891c..0a46cf1 100644
--- a/src/amdgpu_probe.c
+++ b/src/amdgpu_probe.c
@@ -56,7 +56,7 @@
 #include <xf86platformBus.h>
 #endif
 
-_X_EXPORT int gAMDGPUEntityIndex = -1;
+int gAMDGPUEntityIndex = -1;
 
 /* Return the options for supported chipset 'n'; NULL otherwise */
 static const OptionInfoRec *AMDGPUAvailableOptions(int chipid, int busid)
-- 
2.16.0



More information about the amd-gfx mailing list