[PATCH xf86-video-amdgpu 19/19] TODO

Michel Dänzer michel at daenzer.net
Tue Apr 10 08:30:53 UTC 2018


On 2018-04-04 04:29 PM, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  todo | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 todo
> 
> diff --git a/todo b/todo
> new file mode 100644
> index 0000000..10c1ad5
> --- /dev/null
> +++ b/todo
> @@ -0,0 +1,9 @@
> + - on amdgpu_probe failure, the pScrn entry is leaked - missing api/examples?

Might be similar to patch 11; does valgrind actually report a leak if
you force this?


> + - introduce xf86ConfigEntity and use it
> + - remove embedded AMDGPUInfoRec::pEnt
> + - consistently use gAMDGPUEntityIndex or getAMDGPUEntityIndex
> + - consistently use of pEnt/entity_num -> pScrn->list[], AMDPRIV
> + - kill off DRI_1_ DRICreatePCIBusID - demote again to DRI1 only in X codebase
> + - compose bus string early & strcmp instead of device_match?
> + - remove embedded AMDGPUInfoRec::PciInfo - reuse EntityInfoRec::chipset, GDevRec::chiIDi, amdgpu_gpu_info::asic_id or ...
> + - use odev to fetch render_node?

I'm afraid I don't really see these as important enough to be tracked
like this.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list