答复: [PATCH 2/2] drm/amd/pp: Remove dead interface

[Quan, Evan]

Reviewed-by: Evan Quan <evan.quan at amd.com>

________________________________
发件人: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> 代表 Rex Zhu <Rex.Zhu at amd.com>
发送时间: 2018年4月13日 16:19:14
收件人: amd-gfx at lists.freedesktop.org
抄送: Zhu, Rex
主题: [PATCH 2/2] drm/amd/pp: Remove dead interface

Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h        |  6 ------
 drivers/gpu/drm/amd/include/kgd_pp_interface.h |  5 -----
 drivers/gpu/drm/amd/powerplay/amd_powerplay.c  | 30 --------------------------
 3 files changed, 41 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h
index 19d8bf5..354c6dc 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h
@@ -349,12 +349,6 @@ enum amdgpu_pcie_gen {
                 ((adev)->powerplay.pp_funcs->set_clockgating_by_smu(\
                         (adev)->powerplay.pp_handle, msg_id))

-#define amdgpu_dpm_notify_smu_memory_info(adev, virtual_addr_low, \
-                       virtual_addr_hi, mc_addr_low, mc_addr_hi, size) \
-               ((adev)->powerplay.pp_funcs->notify_smu_memory_info)( \
-                       (adev)->powerplay.pp_handle, virtual_addr_low, \
-                       virtual_addr_hi, mc_addr_low, mc_addr_hi, size)
-
 #define amdgpu_dpm_get_power_profile_mode(adev, buf) \
                 ((adev)->powerplay.pp_funcs->get_power_profile_mode(\
                         (adev)->powerplay.pp_handle, buf))
diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
index 1bec907..01969b1 100644
--- a/drivers/gpu/drm/amd/include/kgd_pp_interface.h
+++ b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
@@ -239,11 +239,6 @@ struct amd_pm_funcs {
         int (*load_firmware)(void *handle);
         int (*wait_for_fw_loading_complete)(void *handle);
         int (*set_clockgating_by_smu)(void *handle, uint32_t msg_id);
-       int (*notify_smu_memory_info)(void *handle, uint32_t virtual_addr_low,
-                                       uint32_t virtual_addr_hi,
-                                       uint32_t mc_addr_low,
-                                       uint32_t mc_addr_hi,
-                                       uint32_t size);
         int (*set_power_limit)(void *handle, uint32_t n);
         int (*get_power_limit)(void *handle, uint32_t *limit, bool default_limit);
 /* export to DC */
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index 0cdfa41..b1e916f 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -935,35 +935,6 @@ static int pp_dpm_switch_power_profile(void *handle,
         return 0;
 }

-static int pp_dpm_notify_smu_memory_info(void *handle,
-                                       uint32_t virtual_addr_low,
-                                       uint32_t virtual_addr_hi,
-                                       uint32_t mc_addr_low,
-                                       uint32_t mc_addr_hi,
-                                       uint32_t size)
-{
-       struct pp_hwmgr *hwmgr = handle;
-       int ret = 0;
-
-       if (!hwmgr || !hwmgr->pm_en)
-               return -EINVAL;
-
-       if (hwmgr->hwmgr_func->notify_cac_buffer_info == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
-               return -EINVAL;
-       }
-
-       mutex_lock(&hwmgr->smu_lock);
-
-       ret = hwmgr->hwmgr_func->notify_cac_buffer_info(hwmgr, virtual_addr_low,
-                                       virtual_addr_hi, mc_addr_low, mc_addr_hi,
-                                       size);
-
-       mutex_unlock(&hwmgr->smu_lock);
-
-       return ret;
-}
-
 static int pp_set_power_limit(void *handle, uint32_t limit)
 {
         struct pp_hwmgr *hwmgr = handle;
@@ -1230,7 +1201,6 @@ static int pp_set_mmhub_powergating_by_smu(void *handle)
         .get_vce_clock_state = pp_dpm_get_vce_clock_state,
         .switch_power_profile = pp_dpm_switch_power_profile,
         .set_clockgating_by_smu = pp_set_clockgating_by_smu,
-       .notify_smu_memory_info = pp_dpm_notify_smu_memory_info,
         .get_power_profile_mode = pp_get_power_profile_mode,
         .set_power_profile_mode = pp_set_power_profile_mode,
         .odn_edit_dpm_table = pp_odn_edit_dpm_table,
--
1.9.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180413/e218d8ad/attachment.html>