[PATCH xf86-video-amdgpu 1/2] Don't call scanout_flip/update with a legacy RandR scanout buffer

Alex Deucher alexdeucher at gmail.com
Tue Apr 24 18:27:03 UTC 2018


On Tue, Apr 24, 2018 at 6:07 AM, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> It means we are not using our own scanout buffers.
>
> Fixes crash when TearFree is supposed to be enabled, but
> drmmode_handle_transform doesn't set crtc->driverIsPerformingTransform.
>
> Bugzilla: https://bugs.freedesktop.org/105736
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  src/amdgpu_kms.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
> index c86c78706..5ea90f90c 100644
> --- a/src/amdgpu_kms.c
> +++ b/src/amdgpu_kms.c
> @@ -1055,6 +1055,9 @@ static void AMDGPUBlockHandler_KMS(BLOCKHANDLER_ARGS_DECL)
>                         xf86CrtcPtr crtc = xf86_config->crtc[c];
>                         drmmode_crtc_private_ptr drmmode_crtc = crtc->driver_private;
>
> +                       if (drmmode_crtc->rotate.pixmap)
> +                               continue;
> +
>                         if (drmmode_crtc->tear_free)
>                                 amdgpu_scanout_flip(pScreen, info, crtc);
>                         else if (drmmode_crtc->scanout[drmmode_crtc->scanout_id].pixmap)
> --
> 2.17.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list