[PATCH 3/4] drm/amdgpu: add unicode AMDGPU_UCODE_ID_VCN

Alex Deucher alexdeucher at gmail.com
Thu Aug 9 15:57:22 UTC 2018


On Thu, Aug 9, 2018 at 11:41 AM, James Zhu <jzhums at gmail.com> wrote:
> Signed-off-by: James Zhu <James.Zhu at amd.com>

The subject doesn't really make sense.  Please also include a patch
description.  This should also be split into two patches, one to add
the new id to the enum and one to add support for VCN to the psp
driver.

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 +
>  drivers/gpu/drm/amd/amdgpu/psp_v10_0.c    | 3 +++
>  2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h
> index edb7baf..bdc472b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h
> @@ -194,6 +194,7 @@ enum AMDGPU_UCODE_ID {
>         AMDGPU_UCODE_ID_SMC,
>         AMDGPU_UCODE_ID_UVD,
>         AMDGPU_UCODE_ID_VCE,
> +       AMDGPU_UCODE_ID_VCN,
>         AMDGPU_UCODE_ID_MAXIMUM,
>  };
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> index 0ff136d..02be34e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> @@ -88,6 +88,9 @@ psp_v10_0_get_fw_type(struct amdgpu_firmware_info *ucode, enum psp_gfx_fw_type *
>         case AMDGPU_UCODE_ID_VCE:
>                 *type = GFX_FW_TYPE_VCE;
>                 break;
> +       case AMDGPU_UCODE_ID_VCN:
> +               *type = GFX_FW_TYPE_VCN;
> +               break;
>         case AMDGPU_UCODE_ID_MAXIMUM:
>         default:
>                 return -EINVAL;
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list