[PATCH] drm/amdgpu/sriov: sriov won't support gfx off

Huang Rui ray.huang at amd.com
Mon Aug 13 06:40:01 UTC 2018


On Mon, Aug 13, 2018 at 02:03:22PM +0800, Tiecheng Zhou wrote:
> Signed-off-by: Tiecheng Zhou <Tiecheng.Zhou at amd.com>

gfxoff feature is only able to be enabled after configure PP_GFXOFF_MASK to
ppfeaturemask. In other words, it isn't enabled by default. It doesn't need
this checking and just bypass amdgpu_gfx_off_ctrl is not correct to set
gfxoff disabled.

Thanks,
Ray

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index 790fd54..e67ab25 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -389,6 +389,8 @@ void amdgpu_gfx_compute_mqd_sw_fini(struct amdgpu_device *adev)
>  
>  void amdgpu_gfx_off_ctrl(struct amdgpu_device *adev, bool enable)
>  {
> +	if (amdgpu_sriov_vf(adev))
> +		return;
>  	if (!(adev->powerplay.pp_feature & PP_GFXOFF_MASK))
>  		return;
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list