[PATCH xf86-video-amdgpu] Use correct FB handle in amdgpu_do_pageflip

Alex Deucher alexdeucher at gmail.com
Thu Aug 16 14:58:42 UTC 2018


On Thu, Aug 16, 2018 at 10:36 AM Michel Dänzer <michel at daenzer.net> wrote:
>
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> We were always using the handle of the client provided FB, which
> prevented RandR transforms from working, and could result in a black
> screen.
>
> Fixes: 9b6782c821e0 "Store FB for each CRTC in drmmode_flipdata_rec"
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Good catch!
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  src/drmmode_display.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index e58e15d7b..be0e6b875 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -3974,7 +3974,7 @@ Bool amdgpu_do_pageflip(ScrnInfoPtr scrn, ClientPtr client,
>                 if (crtc == ref_crtc) {
>                         if (drmmode_page_flip_target_absolute(pAMDGPUEnt,
>                                                               drmmode_crtc,
> -                                                             fb->handle,
> +                                                             flipdata->fb[i]->handle,
>                                                               flip_flags,
>                                                               drm_queue_seq,
>                                                               target_msc) != 0)
> @@ -3982,7 +3982,7 @@ Bool amdgpu_do_pageflip(ScrnInfoPtr scrn, ClientPtr client,
>                 } else {
>                         if (drmmode_page_flip_target_relative(pAMDGPUEnt,
>                                                               drmmode_crtc,
> -                                                             fb->handle,
> +                                                             flipdata->fb[i]->handle,
>                                                               flip_flags,
>                                                               drm_queue_seq, 0) != 0)
>                                 goto flip_error;
> --
> 2.18.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list