[PATCH 2/2] drm/amdgpu: fix incorrect use of drm_file->pid

[Alex Deucher]

On Fri, Aug 17, 2018 at 1:42 PM Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> That's the PID of the creator of the file (usually the X server) and not
> the end user of the file.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> CC: stable at vger.kernel.org

Series is:
Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 19 ++++---------------
>  1 file changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c
> index cb62a90d0686..1cafe8d83a4d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c
> @@ -55,7 +55,6 @@ static int amdgpu_sched_process_priority_override(struct amdgpu_device *adev,
>  {
>         struct file *filp = fget(fd);
>         struct drm_file *file;
> -       struct pid *pid;
>         struct amdgpu_fpriv *fpriv;
>         struct amdgpu_ctx *ctx;
>         uint32_t id;
> @@ -63,20 +62,10 @@ static int amdgpu_sched_process_priority_override(struct amdgpu_device *adev,
>         if (!filp)
>                 return -EINVAL;
>
> -       pid = get_pid(((struct drm_file *)filp->private_data)->pid);
> -
> -       mutex_lock(&adev->ddev->filelist_mutex);
> -       list_for_each_entry(file, &adev->ddev->filelist, lhead) {
> -               if (file->pid != pid)
> -                       continue;
> -
> -               fpriv = file->driver_priv;
> -               idr_for_each_entry(&fpriv->ctx_mgr.ctx_handles, ctx, id)
> -                               amdgpu_ctx_priority_override(ctx, priority);
> -       }
> -       mutex_unlock(&adev->ddev->filelist_mutex);
> -
> -       put_pid(pid);
> +       file = filp->private_data;
> +       fpriv = file->driver_priv;
> +       idr_for_each_entry(&fpriv->ctx_mgr.ctx_handles, ctx, id)
> +               amdgpu_ctx_priority_override(ctx, priority);
>
>         fput(filp);
>
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx