[PATCH] drm/amdgpu: fix VM clearing for the root PD

Zhang, Jerry (Junwei) Jerry.Zhang at amd.com
Mon Aug 20 01:28:04 UTC 2018


On 08/17/2018 08:24 PM, Christian König wrote:
> We need to figure out the address after validating the BO, not before.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 662e8a34d52c..662aec5c81d4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -369,7 +369,6 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev,
>   	uint64_t addr;
>   	int r;
>
> -	addr = amdgpu_bo_gpu_offset(bo);
>   	entries = amdgpu_bo_size(bo) / 8;
>
>   	if (pte_support_ats) {
> @@ -401,6 +400,7 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev,
>   	if (r)
>   		goto error;
>
> +	addr = amdgpu_bo_gpu_offset(bo);
>   	if (ats_entries) {
>   		uint64_t ats_value;
>
>


More information about the amd-gfx mailing list