[PATCH v2] drm/amdgpu/sriov: Only sriov runtime support use kiq

[Deng, Emily]

>-----Original Message-----
>From: Christian König <ckoenig.leichtzumerken at gmail.com>
>Sent: Tuesday, August 21, 2018 3:51 PM
>To: Deng, Emily <Emily.Deng at amd.com>; amd-gfx at lists.freedesktop.org
>Subject: Re: [PATCH v2] drm/amdgpu/sriov: Only sriov runtime support use kiq
>
>Am 21.08.2018 um 07:16 schrieb Emily Deng:
>> Refine the code style, add brackets.
>>
>> For sriov, don't use kiq in exclusive mode, as don't know how long
>> time it will take, some times it will occur exclusive timeout.
>>
>> Signed-off-by: Emily Deng <Emily.Deng at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> index f71615e..adfd0bd 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> @@ -320,7 +320,7 @@ signed long  amdgpu_kiq_reg_write_reg_wait(struct
>amdgpu_device *adev,
>>   	struct amdgpu_kiq *kiq = &adev->gfx.kiq;
>>   	struct amdgpu_ring *ring = &kiq->ring;
>>
>> -	if (!ring->ready)
>> +	if (!ring->ready || (!amdgpu_sriov_runtime(adev) &&
>> +amdgpu_sriov_vf(adev)))
>
>Please rework the code flow a bit to make it more obvious what happens here.
>
>E.g. move the check into the caller instead of returning an error code here.
Thanks, will refine.

>Christian.
>
>>   		return -EINVAL;
>>
>>   	spin_lock_irqsave(&kiq->ring_lock, flags);