[PATCH 1/3] drm/amdgpu: Fix vce initialize failed on Kaveri/Mullins

[Michel Dänzer]

On 2018-08-23 2:59 p.m., Zhu, Rex wrote:
>> From: Michel Dänzer <michel at daenzer.net>
>> On 2018-08-23 11:24 a.m., Rex Zhu wrote:
>>> Forgot to add vce pg support via smu for Kaveri/Mullins.
>>>
>>> Regresstion issue caused by
>>> 'commit 561a5c83eadd ("drm/amd/pp: Unify powergate_uvd/vce/mmhub
>> to
>>> set_powergating_by_smu")'
>>
>> You can replace this paragraph with
>>
>> Fixes: 561a5c83eadd ("drm/amd/pp: Unify powergate_uvd/vce/mmhub
>>                       to set_powergating_by_smu")
>>
>>
>> This patch fixes the VCE ring (and also IB) test on this laptop, thanks!
>>
>> Unfortunately though, there's still an oops if I let the amdkfd driver load
>> together with amdgpu (no issue when loading amdkfd manually later), see
>> the attached kernel.log excerpt. This is also a regression in the
>> 4.19 drm tree changes. It might be a separate issue, but TBH I don't feel like
>> another day or two bisecting right now. :)
> 
> Thanks Michel,  I will check the oops issue tomorrow.

FWIW, it does seem related: I re-tested the commit before 561a5c83eadd,
the oops doesn't happen there. But it does happen with only this patch
on top of 561a5c83eadd.

I suspect https://bugs.freedesktop.org/107595 could similarly be at
least triggered by this change (I'm not using DC yet on this laptop).


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer