[PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini

[Zhu, Rex]

> -----Original Message-----
> From: Michel Dänzer <michel at daenzer.net>
> Sent: Friday, August 24, 2018 5:31 PM
> To: Zhu, Rex <Rex.Zhu at amd.com>
> Cc: amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini
> 
> On 2018-08-24 10:50 a.m., Rex Zhu wrote:
> > when hw_fini/suspend, smu only need to power on uvd block if uvd pg is
> > supported, don't need to call uvd to do hw_init.
> >
> > v2: fix typo in patch descriptions.
> >
> > Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
> > b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
> > index b497c37..ce81a53 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c
> > @@ -65,7 +65,6 @@ static int kv_set_thermal_temperature_range(struct
> amdgpu_device *adev,
> >  					    int min_temp, int max_temp);  static
> int
> > kv_init_fps_limits(struct amdgpu_device *adev);
> >
> > -static void kv_dpm_powergate_uvd(void *handle, bool gate);  static
> > void kv_dpm_powergate_samu(struct amdgpu_device *adev, bool gate);
> > static void kv_dpm_powergate_acp(struct amdgpu_device *adev, bool
> > gate);
> >
> > @@ -1388,7 +1387,8 @@ static void kv_dpm_disable(struct
> amdgpu_device *adev)
> >  	kv_dpm_powergate_samu(adev, false);
> >  	if (pi->caps_vce_pg) /* power on the VCE block */
> >  		amdgpu_kv_notify_message_to_smu(adev,
> PPSMC_MSG_VCEPowerON);
> > -	kv_dpm_powergate_uvd(adev, false);
> > +	if (pi->caps_uvd_pg) /* power off the UVD block */
> > +		amdgpu_kv_notify_message_to_smu(adev,
> PPSMC_MSG_UVDPowerON);
> 
> This comment still seems inconsistent with the code.

Thanks. I will fix it immediately.

Regards
Rex

 
> Apart from that, this series is

> Tested-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> 
> Thanks!
> 
> 
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer