[PATCH] drm/amdgpu: Update XGMI node print

Liu, Shaoyun Shaoyun.Liu at amd.com
Mon Dec 3 21:02:43 UTC 2018


I'm ok with that change .

Regards

shaoyun.liu


On 2018-12-03 3:32 p.m., Kuehling, Felix wrote:
> Shaoyun, FYI
>
>
> Acked-by: Felix Kuehling <Felix.Kuehling at amd.com>
>
>
> On 2018-12-03 3:28 p.m., Deucher, Alexander wrote:
>> Acked-by: Alex Deucher <alexander.deucher at amd.com>
>>
>> ------------------------------------------------------------------------
>> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of
>> Andrey Grodzovsky <andrey.grodzovsky at amd.com>
>> *Sent:* Monday, December 3, 2018 3:03:41 PM
>> *To:* amd-gfx at lists.freedesktop.org
>> *Cc:* Deucher, Alexander; Grodzovsky, Andrey
>> *Subject:* [PATCH] drm/amdgpu: Update XGMI node print
>>   
>> amdgpu_xgmi_update_topology is called both on device registration
>> and reset. Fix misleading print since the device is added only once to
>> the hive on registration and not on reset.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
>> index 1b15ff3..0b263a9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
>> @@ -78,7 +78,7 @@ int amdgpu_xgmi_update_topology(struct
>> amdgpu_hive_info *hive, struct amdgpu_dev
>>                           adev->gmc.xgmi.node_id,
>>                           adev->gmc.xgmi.hive_id, ret);
>>           else
>> -               dev_info(adev->dev, "XGMI: Add node %d to hive 0x%llx.\n",
>> +               dev_info(adev->dev, "XGMI: Set topology for node %d,
>> hive 0x%llx.\n",
>>                            adev->gmc.xgmi.physical_node_id,
>>                                    adev->gmc.xgmi.hive_id);
>>   
>> -- 
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list