[PATCH] drm/amdgpu: Skip ring soft recovery when fence was NULL

Christian König ckoenig.leichtzumerken at gmail.com
Thu Dec 6 09:31:49 UTC 2018


Am 06.12.18 um 03:42 schrieb wentalou:
> amdgpu_ring_soft_recovery would have Call-Trace,
> when s_fence->parent was NULL inside amdgpu_job_timedout.
> Check fence first, as drm_sched_hw_job_reset did.
>
> Change-Id: Ibb062e36feb4e2522a59641fe0d2d76b9773cda7
> Signed-off-by: Wentao Lou <Wentao.Lou at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> index 5b75bdc..335a0ed 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> @@ -397,7 +397,7 @@ bool amdgpu_ring_soft_recovery(struct amdgpu_ring *ring, unsigned int vmid,
>   {
>   	ktime_t deadline = ktime_add_us(ktime_get(), 10000);
>   
> -	if (!ring->funcs->soft_recovery)
> +	if (!ring->funcs->soft_recovery || !fence)
>   		return false;
>   
>   	atomic_inc(&ring->adev->gpu_reset_counter);



More information about the amd-gfx mailing list