[PATCH] drm/amd/display: Fix duplicating scaling/underscan connector state

[Alex Deucher]

Acked-by: Alex Deucher <alexander.deucher at amd.com>
On Fri, Dec 7, 2018 at 10:07 AM Nicholas Kazlauskas
<nicholas.kazlauskas at amd.com> wrote:
>
> [Why]
> These properties aren't being carried over when the atomic state.
> This tricks atomic check and commit tail into performing underscan
> and scaling operations when they aren't needed.
>
> With the patch that forced scaling/RMX_ASPECT on by default this
> results in many unnecessary surface updates and hangs under certain
> conditions.
>
> [How]
> Duplicate the properties.
>
> Fixes: 91b66c47ba34 ("drm/amd/display: Set RMX_ASPECT as default")
>
> Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com>
> Cc: Leo Li <sunpeng.li at amd.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 23d61570df17..ddf5efd1a5f4 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3242,6 +3242,10 @@ amdgpu_dm_connector_atomic_duplicate_state(struct drm_connector *connector)
>
>         new_state->freesync_capable = state->freesync_capable;
>         new_state->abm_level = state->abm_level;
> +       new_state->scaling = state->scaling;
> +       new_state->underscan_enable = state->underscan_enable;
> +       new_state->underscan_hborder = state->underscan_hborder;
> +       new_state->underscan_vborder = state->underscan_vborder;
>         new_state->max_bpc = state->max_bpc;
>
>         return &new_state->base;
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx