[PATCH -next] drm/amdgpu: remove set but not used variable 'grbm_soft_reset'

Zhou, David(ChunMing) David1.Zhou at amd.com
Mon Dec 10 02:48:53 UTC 2018



> -----Original Message-----
> From: YueHaibing <yuehaibing at huawei.com>
> Sent: Saturday, December 08, 2018 11:01 PM
> To: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; Zhou, David(ChunMing)
> <David1.Zhou at amd.com>; airlied at linux.ie; Liu, Leo <Leo.Liu at amd.com>;
> Gao, Likun <Likun.Gao at amd.com>; Panariti, David
> <David.Panariti at amd.com>; S, Shirish <Shirish.S at amd.com>; Zhu, Rex
> <Rex.Zhu at amd.com>; Grodzovsky, Andrey <Andrey.Grodzovsky at amd.com>
> Cc: YueHaibing <yuehaibing at huawei.com>; amd-gfx at lists.freedesktop.org;
> dri-devel at lists.freedesktop.org; linux-kernel at vger.kernel.org; kernel-
> janitors at vger.kernel.org
> Subject: [PATCH -next] drm/amdgpu: remove set but not used variable
> 'grbm_soft_reset'
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function
> 'gfx_v8_0_pre_soft_reset':
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:4950:27: warning:
>  variable 'srbm_soft_reset' set but not used [-Wunused-but-set-variable]
> 
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function
> 'gfx_v8_0_post_soft_reset':
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:5054:27: warning:
>  variable 'srbm_soft_reset' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction in commit d31a501ead7f ("drm/amdgpu: add
> pre_soft_reset ip func") and e4ae0fc33631 ("drm/amdgpu: implement
> gfx8 post_soft_reset")
> 
> Signed-off-by: YueHaibing <yuehaibing at huawei.com>

Reviewed-by: Chunming Zhou <david1.zhou at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 1454fc3..8c1ba79 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -4947,14 +4947,13 @@ static bool gfx_v8_0_check_soft_reset(void
> *handle)  static int gfx_v8_0_pre_soft_reset(void *handle)  {
>  	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> -	u32 grbm_soft_reset = 0, srbm_soft_reset = 0;
> +	u32 grbm_soft_reset = 0;
> 
>  	if ((!adev->gfx.grbm_soft_reset) &&
>  	    (!adev->gfx.srbm_soft_reset))
>  		return 0;
> 
>  	grbm_soft_reset = adev->gfx.grbm_soft_reset;
> -	srbm_soft_reset = adev->gfx.srbm_soft_reset;
> 
>  	/* stop the rlc */
>  	adev->gfx.rlc.funcs->stop(adev);
> @@ -5051,14 +5050,13 @@ static int gfx_v8_0_soft_reset(void *handle)
> static int gfx_v8_0_post_soft_reset(void *handle)  {
>  	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> -	u32 grbm_soft_reset = 0, srbm_soft_reset = 0;
> +	u32 grbm_soft_reset = 0;
> 
>  	if ((!adev->gfx.grbm_soft_reset) &&
>  	    (!adev->gfx.srbm_soft_reset))
>  		return 0;
> 
>  	grbm_soft_reset = adev->gfx.grbm_soft_reset;
> -	srbm_soft_reset = adev->gfx.srbm_soft_reset;
> 
>  	if (REG_GET_FIELD(grbm_soft_reset, GRBM_SOFT_RESET,
> SOFT_RESET_CP) ||
>  	    REG_GET_FIELD(grbm_soft_reset, GRBM_SOFT_RESET,
> SOFT_RESET_CPF) ||
> 
> 



More information about the amd-gfx mailing list